Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libavif: init at 0.8.1 #98306

Closed
wants to merge 1 commit into from
Closed

libavif: init at 0.8.1 #98306

wants to merge 1 commit into from

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Sep 19, 2020

Motivation for this change

Add https://github.com/AOMediaCodec/libavif

Fixes #98303
cc: @mkg20001

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mkg20001
Copy link
Member

uh just the same second I made #98307

I added the tools to that build aswell since that's what I needed... not sure if there should be a seperate packaeg since tools add dependencies that aren't needed for the devs

@symphorien
Copy link
Member

The tools can be put in another output

@mkg20001
Copy link
Member

I have #98307 ready with the tools but after adding "bin" output it told me that there were circular references after building... dunno what I did wrong

@symphorien
Copy link
Member

Circular dependencies means that for some reason, the dev output depends on on the bin output, so when you install the lib you have to install the tools as well. Either this makes sense, and then there is no reason to make the derivation multiple output, or this means that some files must be moved from $dev to $bin in postInstall for example.

@mkg20001
Copy link
Member

It also has been happening with just adding bin, so unsure...

@marsam
Copy link
Contributor Author

marsam commented Sep 20, 2020

closing in favor of #98307

@marsam marsam closed this Sep 20, 2020
@marsam marsam deleted the init-libavif branch September 20, 2020 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RFP: libavif
3 participants