Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] python3Packages.lightparam: fix source and deps #98305

Merged
merged 1 commit into from Sep 20, 2020
Merged

[20.09] python3Packages.lightparam: fix source and deps #98305

merged 1 commit into from Sep 20, 2020

Conversation

jonringer
Copy link
Contributor

Motivation for this change

backport #98065

(cherry picked from commit 2a35f66)

ZHF: #97479

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer jonringer changed the title python3Packages.lightparam: fix source and deps [20.09] python3Packages.lightparam: fix source and deps Sep 19, 2020
@ofborg ofborg bot requested a review from tbenst September 19, 2020 23:32
@jonringer
Copy link
Contributor Author 

https://github.com/NixOS/nixpkgs/pull/98305
4 packages built:
python37Packages.lightparam python37Packages.stytra python38Packages.lightparam python38Packages.stytra

@jonringer jonringer merged commit 5a6ec51 into NixOS:release-20.09 Sep 20, 2020
@jonringer jonringer deleted the backport-lightparam branch September 20, 2020 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh FRidh is a code owner

@tbenst tbenst Awaiting requested review from tbenst

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@jonringer