Upload tests for font metrics override descriptors to WPT #25638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Sep 19, 2020
Following the standardization of @font-face descriptors ascent-override, descent-override and line-gap-override, this patch uploads the existing test cases to WPT as test coverage. This resolves the "Need Testcase (WPT)" label in w3c/csswg-drafts#4792 Bug: 1098355 Change-Id: Iffadff1fb159e52ca5a0675259381401fbe90c99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419585 Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#808665}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2419585
branch
from
4d15cf2
to
f220e66
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the standardization of @font-face descriptors ascent-override,
descent-override and line-gap-override, this patch uploads the existing
test cases to WPT as test coverage.
This resolves the "Need Testcase (WPT)" label in
w3c/csswg-drafts#4792
Bug: 1098355
Change-Id: Iffadff1fb159e52ca5a0675259381401fbe90c99
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419585
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808665}