Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.sslyze: downgrade cryptography to 2.9 #98255

Closed
wants to merge 1 commit into from
Closed

pythonPackages.sslyze: downgrade cryptography to 2.9 #98255

wants to merge 1 commit into from

Conversation

mweinelt
Copy link
Member

Motivation for this change

The sslyze package is not compatible with cryptography>=3.0. We still have the 2.9 version around for python2, expose it as cryptography_2_9 and use that.

ZHF #97479

https://hydra.nixos.org/build/126784363/nixlog/1

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mweinelt
Copy link
Member Author

mweinelt commented Sep 19, 2020 •
edited

Still references the wrong cryptography_vectors package. Aaaand infinite recursion. I'm out.

@mweinelt mweinelt closed this Sep 19, 2020
@mweinelt mweinelt deleted the python/sslyze branch September 19, 2020 02:13
@AndersonTorres
Copy link
Member

Mark the package as broken, then?

@mweinelt
Copy link
Member Author

Apparently it works with cryptography 3.x, see #98301.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mweinelt @AndersonTorres