Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gitolite: fix updating of gitweb access list and description #98262

Merged
merged 1 commit into from Sep 19, 2020
Merged

gitolite: fix updating of gitweb access list and description #98262

merged 1 commit into from Sep 19, 2020

Conversation

ju1m
Copy link
Contributor

@ju1m ju1m commented Sep 19, 2020

Motivation for this change

Currently when git push a gitolite repository:

remote: /nix/store/apcg7hcpaiy5ajy73y59fxhddxgszz4f-gitolite-3.6.12/bin/triggers/post-compile/update-gitweb-access-list: line 39: perl: command not found
remote: /nix/store/apcg7hcpaiy5ajy73y59fxhddxgszz4f-gitolite-3.6.12/bin/triggers/post-compile/update-description-file: line 13: perl: command not found
Things done
  • Add perl to gitolite-shell's `PATH.
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ju1m ju1m changed the title Fix gitolite updating of gitweb access list and description gitolite: fix updating of gitweb access list and description Sep 19, 2020
@Lassulus Lassulus merged commit 8779fd7 into NixOS:master Sep 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomberek tomberek tomberek approved these changes

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

@Lassulus Lassulus Awaiting requested review from Lassulus

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ju1m @tomberek @Lassulus