Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add github-based authentication and authorization #5

Merged
merged 7 commits into from Sep 19, 2020

Conversation

frosch123
Copy link
Member

No description provided.

Copy link
Member

@TrueBrain TrueBrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is difficult to read for me, as it doesn't follow PEP-8 (which most (all?) Python code follows. But I did my best.

Also, I don't really understand the full flow of this codebase, but that is because I am only seeing a small part. It "looks okay", from what I can read. So except for some comments, which are mostly nitpicks, LGTM.

webtranslate/main.py Show resolved Hide resolved
webtranslate/pages/delete.py Show resolved Hide resolved
webtranslate/pages/login.py Outdated Show resolved Hide resolved
webtranslate/pages/login.py Outdated Show resolved Hide resolved
webtranslate/pages/newlanguage.py Outdated Show resolved Hide resolved
webtranslate/users/development.py Show resolved Hide resolved
webtranslate/users/github.py Outdated Show resolved Hide resolved
webtranslate/users/github.py Outdated Show resolved Hide resolved
webtranslate/users/github.py Show resolved Hide resolved
webtranslate/users/github.py Outdated Show resolved Hide resolved
Copy link
Member

@TrueBrain TrueBrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YOLO

@frosch123 frosch123 merged commit deb34a1 into OpenTTD:master Sep 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants