Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.mock-open: 1.3.1 -> 1.4.0 #98313

Merged
merged 2 commits into from Sep 20, 2020
Merged

pythonPackages.mock-open: 1.3.1 -> 1.4.0 #98313

merged 2 commits into from Sep 20, 2020

Conversation

das-g
Copy link
Member

@das-g das-g commented Sep 20, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
    • ❌ meta.maintainers is not set

das-g
das-g commented Sep 20, 2020
View reviewed changes
pkgs/development/python-modules/mock-open/default.nix
(fetchpatch {
name = "ascii-only.patch";
url = "https://github.com/das-g/mock-open/commit/521ff260da127949fe4aceff1667cba223c5b07b.patch";
sha256 = "0ampbhk7kwkn0q5d2h9wrflkr8fji2bybmdck4qdzw1qkslfwwrn";
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This patch (from nivbend/mock-open#10) is only needed on Python 2. Should it be applied unconditionally or only when building for Python 2? (It doesn't do any harm on Python 3.)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd make py2-only because any patch has the possibility to cause problems that stop us auto-bumping.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed with https://github.com/NixOS/nixpkgs/compare/f19d0ea6acd1703c85ade318c54d4f157053aa4d..399d7afeb67b660d4691cc8d59fbb949699a39c6

@das-g
Copy link
Member Author

das-g commented Sep 20, 2020

Result of nixpkgs-review pr 98313 1

3 packages built:
  • python27Packages.mock-open
  • python37Packages.mock-open
  • python38Packages.mock-open

@risicle
Copy link
Contributor

risicle commented Sep 20, 2020

WFM macos 10.14, non-nixos linux x86_64.

@das-g
Copy link
Member Author

das-g commented Sep 20, 2020

Result of nixpkgs-review pr 98313 1

3 packages built:
  • python27Packages.mock-open
  • python37Packages.mock-open
  • python38Packages.mock-open

@das-g das-g requested a review from risicle September 20, 2020 13:30
@risicle
Copy link
Contributor

risicle commented Sep 20, 2020

LGTM

jonringer
jonringer approved these changes Sep 20, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 98313 1

3 packages built:
  • python27Packages.mock-open
  • python37Packages.mock-open
  • python38Packages.mock-open

@jonringer jonringer merged commit 355d255 into NixOS:master Sep 20, 2020
@jonringer jonringer added the 9.needs: port to stable A PR needs a backport to the stable release. label Sep 20, 2020
@das-g das-g deleted the pythonPackages_mock-open branch September 20, 2020 20:39
@das-g das-g mentioned this pull request Sep 20, 2020
Merged
10 tasks
@das-g das-g mentioned this pull request Oct 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@risicle risicle risicle approved these changes

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 9.needs: port to stable A PR needs a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@das-g @risicle @jonringer