Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dmenu: 4.9 -> 5.0 #98267

Merged
merged 1 commit into from Nov 24, 2020
Merged

dmenu: 4.9 -> 5.0 #98267

merged 1 commit into from Nov 24, 2020

Conversation

oxzi
Copy link
Member

@oxzi oxzi commented Sep 19, 2020

Motivation for this change

Bump dmenu.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from globin and pSub September 19, 2020 10:10
@RaghavSood
Copy link
Member

Result of nixpkgs-review pr 98267 1

1 package blacklisted:
  • tests.nixos-functions.nixos-test
18 packages built:
  • clipmenu
  • connman_dmenu
  • dmensamenu
  • dmenu
  • j4-dmenu-desktop
  • krunner-pass
  • pass
  • pass-wayland
  • passExtensions.pass-audit
  • passExtensions.pass-import
  • passff-host
  • python27Packages.dmenu-python
  • python37Packages.dmenu-python
  • python38Packages.dmenu-python
  • qtpass
  • rofi-pass
  • surf
  • surf-display

@pSub pSub merged commit 4c4de46 into NixOS:master Nov 24, 2020
@oxzi oxzi deleted the dmenu-5.0 branch November 24, 2020 09:53
@oxzi oxzi mentioned this pull request Nov 24, 2020
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pSub pSub pSub approved these changes

@RaghavSood RaghavSood RaghavSood approved these changes

@globin globin Awaiting requested review from globin

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@oxzi @RaghavSood @pSub