Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove joncojonathan as maintainer #98266

Merged
merged 4 commits into from Sep 20, 2020
Merged

Remove joncojonathan as maintainer #98266

merged 4 commits into from Sep 20, 2020

Conversation

joncojonathan
Copy link
Member

Motivation for this change

Due to other projects I need to step away from NixOS for the moment. As such I'm removing myself as a maintainer. I hope to return some day.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@joncojonathan
Copy link
Member Author

Removed trailing whitespace on the Gramps derivation as found by EditorConfig checks (fb8ad44770a1a0b6a2cfd8b61cde41a66b1df819).

@danieldk
Copy link
Contributor

Thanks for tidying up! I have reformatted the commit messages a bit and made one formatting change to (hopefully) make CI happy.

Thanks for your contributions 👍 . Hope to see you back one day!

@danieldk danieldk merged commit 770ecb1 into NixOS:master Sep 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldk danieldk danieldk approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@joncojonathan @danieldk