cli: error when no applet is specified #203
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I am not sure how this came to be but apparently args.applet could be None, so we
need to check its value.
Traceback (most recent call last):
File "/home/anubis/.virtualenvs/glasgow/bin/glasgow", line 11, in <module>
load_entry_point('glasgow', 'console_scripts', 'glasgow')()
File "/home/anubis/git/glasgow/software/glasgow/cli.py", line 803, in main
exit(loop.run_until_complete(_main()))
File "/usr/lib/python3.8/asyncio/base_events.py", line 616, in run_until_complete
return future.result()
File "/home/anubis/git/glasgow/software/glasgow/cli.py", line 490, in _main
target, applet = _applet(device.revision, args)
File "/home/anubis/git/glasgow/software/glasgow/cli.py", line 336, in _applet
applet = GlasgowApplet.all_applets[args.applet]()
KeyError: None
Signed-off-by: Filipe Laíns <lains@archlinux.org>
whitequark
requested changes
Sep 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not sure how this came to be but apparently args.applet could be None, so we
need to check its value.
Signed-off-by: Filipe Laíns lains@archlinux.org