Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

performance-timeline/po-observe.html should not hardcode entry types #25641

Open
samweinig opened this issue Sep 19, 2020 · 1 comment
Open

performance-timeline/po-observe.html should not hardcode entry types #25641

samweinig opened this issue Sep 19, 2020 · 1 comment
Labels
performance-timeline

Comments

@samweinig
Copy link
Contributor

The test performance-timeline/po-observe.html currently hardcodes the list of entry types it needs to observe (see https://github.com/web-platform-tests/wpt/blob/master/performance-timeline/po-observe.html#L81) but really should be filtering that list by PerformanceObserver.supportedEntryTypes so that the test limits itself to only testing performance-timeline defined things and is not reliant on the implementation having implemented other standards not strictly needed to test the functionality.
@sideshowbarker
Copy link
Contributor

dunno who’s responsible for the Performance Timeline test suite these days, but maybe @plh @caribouW3 can help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
performance-timeline
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gsnedders @sideshowbarker @samweinig