Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/prometheus: remote_{read,write} support #99180

Merged
merged 1 commit into from Dec 29, 2020
Merged

nixos/prometheus: remote_{read,write} support #99180

merged 1 commit into from Dec 29, 2020

Conversation

0x4A6F
Copy link
Member

@0x4A6F 0x4A6F commented Sep 30, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@0x4A6F 0x4A6F mentioned this pull request Sep 30, 2020
Closed
10 tasks
@0x4A6F 0x4A6F marked this pull request as ready for review September 30, 2020 18:12
@0x4A6F 0x4A6F changed the title nixos/prometheus: nixos/prometheus: remote_{read,write} Oct 1, 2020
@0x4A6F 0x4A6F requested a review from basvandijk October 6, 2020 17:33
@0x4A6F 0x4A6F changed the title nixos/prometheus: remote_{read,write} nixos/prometheus: remote_{read,write} support Oct 6, 2020
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/324

@0x4A6F 0x4A6F requested a review from dtzWill December 29, 2020 13:49
@0x4A6F
Copy link
Member Author

0x4A6F commented Dec 29, 2020

Updated based on work in #107398.

@0x4A6F 0x4A6F requested review from WilliButz and removed request for dtzWill December 29, 2020 14:30
@WilliButz
Copy link
Member

@GrahamcOfBorg test prometheus

WilliButz
WilliButz approved these changes Dec 29, 2020
View reviewed changes
Copy link
Member

@WilliButz WilliButz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@WilliButz WilliButz merged commit 6739d17 into NixOS:master Dec 29, 2020
@WilliButz WilliButz mentioned this pull request Dec 29, 2020
Closed
10 tasks
@0x4A6F 0x4A6F deleted the master-prometheus-service branch December 31, 2020 17:49
@flokli
Copy link
Contributor

flokli commented Jan 16, 2021

@WilliButz @0x4A6F any reservations against backporting this to 20.09? It shouldn't affect existing configs.

@flokli flokli mentioned this pull request Jan 16, 2021
Merged
10 tasks
@0x4A6F
Copy link
Member Author

0x4A6F commented Jan 16, 2021

No objections from my side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WilliButz WilliButz WilliButz approved these changes

@basvandijk basvandijk Awaiting requested review from basvandijk

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@0x4A6F @nixos-discourse @WilliButz @flokli