Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecation notice for binary_cache_secret_key_file #820

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove deprecation notice for binary_cache_secret_key_file #820

wants to merge 1 commit into from

Conversation

Taneb
Copy link
Contributor

@Taneb Taneb commented Sep 30, 2020 •
edited

It's still used for signing narinfo files if using Hydra as a binary cache server. See https://github.com/NixOS/hydra/blob/master/src/lib/Hydra/View/NARInfo.pm#L37

See also issues #548 and #679

Remove deprecation notice for binary_cache_secret_key_file
df3262e 
It's still used for signing `narinfo` files if using Hydra as a binary cache server. See https://github.com/NixOS/hydra/blob/master/src/lib/Hydra/View/NARInfo.pm#L37
@ivan
Copy link
Member

ivan commented Oct 9, 2022 •
edited

Please merge this; the deprecation warning was very confusing to me as someone using a local store with store_uri = auto:

hydra-send-stats[3536553]: hydra.conf: binary_cache_secret_key_file is deprecated and ignored. use store_uri=...?secret-key= instead
  1. It is not ignored with store_uri = auto and AFAIK binary_cache_secret_key_file is the only way have your packages be signed when they're downloaded over ssh:// (unless you choose to run nix store sign --all -k /var/secrets/nix/secret_key all the time).
  2. store_uri=...?secret-key= does not work for auto as mentioned in suggested replacement for binary_cache_secret_key_file is dysfunctional  #679 (comment)

Sorry, I probably tested wrong because my signing problem is still unsolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Taneb @ivan