Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AspectRatio] Fix incorrect test #25887

Merged
merged 1 commit into from Oct 1, 2020

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Sep 30, 2020

As per w3c/csswg-drafts#5084, serializing
the specified style for 0/0 should remain 0/0; only computed style
should change.

R=futhark@chromium.org

Bug: 1086606
Change-Id: Iedf56b7dbcb3d0268db8d34d5a554c54a3bdafac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439647
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Auto-Submit: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812646}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

@cbiesinger
Copy link
Contributor

@BorisChiou fyi

@BorisChiou
Copy link
Member

Thanks!

As per w3c/csswg-drafts#5084, serializing
the specified style for 0/0 should remain 0/0; only computed style
should change.

R=futhark@chromium.org

Bug: 1086606
Change-Id: Iedf56b7dbcb3d0268db8d34d5a554c54a3bdafac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439647
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Auto-Submit: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812646}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants