Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ClockRecoveryFilter.cpp => ClockRecoveryFilter::Refresh() Uninitialized variable: ps #292

Closed
bvernoux opened this issue Sep 30, 2020 · 0 comments

Comments

@bvernoux
Copy link
Contributor

See https://github.com/azonenberg/scopehal/blob/7887aa488274ea0447779058f67d68b124d9160a/scopeprotocols/ClockRecoveryFilter.cpp#L135
Code extract
int64_t ps = round(ps);
There is clearly a bug here

@bvernoux bvernoux changed the title ClockRecoveryFilter.cpp => ClockRecoveryFilter::Refresh() unitialized variable ps ClockRecoveryFilter.cpp => ClockRecoveryFilter::Refresh() [C:/msys64/home/Ben/scopehal-apps/lib/scopeprotocols/ClockRecoveryFilter.cpp:135] (error) Uninitialized variable: ps Sep 30, 2020
@bvernoux bvernoux changed the title ClockRecoveryFilter.cpp => ClockRecoveryFilter::Refresh() [C:/msys64/home/Ben/scopehal-apps/lib/scopeprotocols/ClockRecoveryFilter.cpp:135] (error) Uninitialized variable: ps ClockRecoveryFilter.cpp => ClockRecoveryFilter::Refresh() Uninitialized variable: ps Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant