Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "nixos/gnome3: launch gnome-shell wayland with RT scheduling" #99147

Closed
wants to merge 1 commit into from
Closed

Revert "nixos/gnome3: launch gnome-shell wayland with RT scheduling" #99147

wants to merge 1 commit into from

Conversation

TredwellGit
Copy link
Member

Motivation for this change

This reverts commit 927a6fd.

Fixes:
#90201
#90184
#86730

That commit adds support for an experimental feature that is disabled by default and has caused multiple people to waste hours debugging. To quote the author of the commit:

I've kinda forgot about the issue, but we should probably disable the wrapper for now since it breaks things (would be nice to get into 20.09). Regardless of our understanding the underlying issue, it's a fairly minor feature which probably aren't used by many people (especially since it's not enabled by default).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

worldofpeace
worldofpeace suggested changes Sep 30, 2020
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#71390 (comment)
#71390 (comment)

^ can we add an option? I actually use this feature, and it's possible some people from unstable still want it.

I would also like to backport to 20.09.

@worldofpeace worldofpeace requested a review from a team September 30, 2020 18:45
@worldofpeace worldofpeace added this to In Progress in GNOME Sep 30, 2020
@worldofpeace worldofpeace added this to the 20.09 milestone Sep 30, 2020
@worldofpeace
Copy link
Contributor

I also can't reproduce one of the bugs for TZDIR #86730 (comment). This could either mean, this actually is working as expected since we know that LD_LIBRARY_PATH is going to be dropped by design, or that it's just broken (or my setup isn't correct) and why I can't reproduce.

@worldofpeace worldofpeace mentioned this pull request Oct 3, 2020
Merged
10 tasks
@worldofpeace
Copy link
Contributor

this is superseded by #99697

@TredwellGit TredwellGit deleted the nixos/gnome3 branch October 6, 2020 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace requested changes

Assignees
No one assigned
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
GNOME
  
In Progress
Milestone
20.09
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@TredwellGit @worldofpeace