Tweak some subsup tests to make them less strict #25871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These tests are sometimes failing on firefox locally, because they depend on the font used. Also the rules when a MATH table is not used are not clear yet and spec and implementations differ. This commit tweaks subsup tests so that: - They use Ahem rather than system fonts. - Error is relaxed. - position of sup/sup script is checked to be above/below the middle of the base than close to the top/bottom of the base.
|
There are no reviewers for this pull request besides its author. Please reach out on W3C's irc server (irc.w3.org, port 6665) on channel #testing (web client) to get help with this. Thank you! |
ziransun
pushed a commit
to ziransun/wpt
that referenced
this pull request
Oct 6, 2020
…25871) These tests are sometimes failing on firefox locally, because they depend on the font used. Also the rules when a MATH table is not used are not clear yet and spec and implementations differ. This commit tweaks subsup tests so that: - They use Ahem rather than system fonts. - Error is relaxed. - position of sup/sup script is checked to be above/below the middle of the base than close to the top/bottom of the base.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests are sometimes failing on firefox locally, because they
depend on the font used. Also the rules when a MATH table is not
used are not clear yet and spec and implementations differ. This
commit tweaks subsup tests so that:
of the base than close to the top/bottom of the base.