Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

meson: Remove propagated native C compiler #99176

Merged
merged 1 commit into from Nov 15, 2020
Merged

meson: Remove propagated native C compiler #99176

merged 1 commit into from Nov 15, 2020

Conversation

Ericson2314
Copy link
Member

Motivation for this change

Now that we have a Meson release containting 1, Meson will work fine
without a native compiler, so we don't need this trick anymore.

Fixes #58831

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

CC @leotaku

@Ericson2314
meson: Remove propagated native C compiler
f60fc7f 
Now that we have a Meson release containting [1], Meson will work fine
without a native compiler, so we don't need this trick anymore.

Fixes NixOS#58831

[1]: mesonbuild/meson#6512
@Ericson2314 Ericson2314 marked this pull request as draft September 30, 2020 14:34
@Ericson2314 Ericson2314 changed the title meson: Remove propagated native C compiler WIP: meson: Remove propagated native C compiler Sep 30, 2020
@ofborg ofborg bot requested a review from jtojnar September 30, 2020 15:06
@leotaku
Copy link
Contributor

leotaku commented Nov 15, 2020

Version 0.56.0 of Meson has recently been merged into Nixpkgs, so I think it would make sense to un-draft this PR and try getting it merged.

@Ericson2314 Ericson2314 changed the base branch from master to staging November 15, 2020 16:21
@Ericson2314 Ericson2314 marked this pull request as ready for review November 15, 2020 16:22
@Ericson2314 Ericson2314 changed the title WIP: meson: Remove propagated native C compiler meson: Remove propagated native C compiler Nov 15, 2020
@Ericson2314
Copy link
Member Author

@leotaku Thanks for letting me know!

@Ericson2314 Ericson2314 merged commit 5bafec3 into NixOS:staging Nov 15, 2020
@Ericson2314 Ericson2314 deleted the meson-remove-extra-cc branch November 15, 2020 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar Awaiting requested review from jtojnar

Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-darwin: 2501-5000 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Meson overrides compiler, ignoring stdenv
2 participants
@Ericson2314 @leotaku