[LayoutNG] Handle fragmenting floats in BFC roots correctly. #25875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Sep 30, 2020
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2438494
branch
from
cda4838
to
de82c5b
Compare
This consists of two fixes: 1. The block formatting context root must not be marked as "at block end" if there are broken floats inside. 2. Set exclusion space correctly. We used to add an "infinitely" tall exclusion, which would cause the containing block (the formatting context root) to become "infinitely" tall. Set it to the amount of space left in the fragmentainer instead. Bug: 829028 Change-Id: I316d7a9b50b9a502d203d83021389274713d2429 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438494 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#812595}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2438494
branch
from
de82c5b
to
2dab727
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This consists of two fixes:
The block formatting context root must not be marked as "at block
end" if there are broken floats inside.
Set exclusion space correctly. We used to add an "infinitely" tall
exclusion, which would cause the containing block (the formatting
context root) to become "infinitely" tall. Set it to the amount of space
left in the fragmentainer instead.
Bug: 829028
Change-Id: I316d7a9b50b9a502d203d83021389274713d2429
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438494
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812595}