NativeIO: Add Error Handling for file errors #25873
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Sep 30, 2020
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2436344
branch
3 times, most recently
from
6093a23
to
91409c3
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2436344
branch
7 times, most recently
from
7eb9855
to
d49ad13
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2436344
branch
5 times, most recently
from
3d51460
to
d7be442
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2436344
branch
3 times, most recently
from
b86ca05
to
76993e0
Compare
This CL adds a mechanism to report file errors, as reported by base::File::Error, though DOMExceptions. Due to security and privacy considerations, not all errors are exposed to the user. For those operations performed by the browser process (open, rename), the exact error type is not exposed to the renderer. Errors that are not reported by base::File::Error are left unchanged and will be addressed in a followup CL. The design document for this change is https://docs.google.com/document/d/1rvs615AU2s8kVsmUlukbmtQNvUWFny0yzAS_gsnYZEs/ Bug: 1095537 Change-Id: If047ddccb6464dd6efb2b06a5da262d049f1e9a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436344 Commit-Queue: Richard Stotz <rstz@chromium.org> Reviewed-by: Victor Costan <pwnall@chromium.org> Reviewed-by: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#829643}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2436344
branch
from
76993e0
to
d0589a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL adds a mechanism to report file errors, as reported by
base::File::Error, though DOMExceptions. Due to security and privacy
considerations, not all errors are exposed to the user. For those
operations performed by the browser process (open, rename), the exact
error type is not exposed to the renderer.
Errors that are not reported by base::File::Error are left unchanged and
will be addressed in a followup CL.
The design document for this change is
https://docs.google.com/document/d/1rvs615AU2s8kVsmUlukbmtQNvUWFny0yzAS_gsnYZEs/
Bug: 1095537
Change-Id: If047ddccb6464dd6efb2b06a5da262d049f1e9a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436344
Commit-Queue: Richard Stotz <rstz@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#829643}
Revert "NativeIO: Add Error Handling for file errors"
This reverts commit df72c8d567074d0a1c22fe963939f3c791f09991.
Reason for revert: external/wpt/native-io/rename_async_failure_handling.tentative.https.any.html
external/wpt/native-io/rename_async_failure_handling.tentative.https.any.serviceworker.html
external/wpt/native-io/rename_async_failure_handling.tentative.https.any.sharedworker.html
external/wpt/native-io/rename_async_failure_handling.tentative.https.any.worker.html failing on multiple bots: https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Win10
https://ci.chromium.org/p/chromium/builders/ci/linux-bfcache-rel
TBR=pwnall@chromium.org,mkwst@chromium.org,krivoy@google.com,rstz@chromium.org
Change-Id: I1078ca3dd40685d711a9717b143f2974d62e084c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1095537
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551842
Reviewed-by: Joshua Pawlicki waffles@chromium.org
Commit-Queue: Joshua Pawlicki waffles@chromium.org
Cr-Commit-Position: refs/heads/master@{#829673}