Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libcoap: 4.2.0 -> 4.2.1 #99175

Merged
merged 1 commit into from Oct 1, 2020
Merged

Conversation

ajs124
Copy link
Member

@ajs124 ajs124 commented Sep 30, 2020

Motivation for this change

Upstream release.

The changelog doesn't contain anything for this release, but it fixes a bug with Uri-Query options for me.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 99175 1

1 package built:
  • libcoap

Verified that the binaries work.

@danieldk danieldk merged commit 7779eb3 into NixOS:master Oct 1, 2020
@ajs124 ajs124 deleted the upd/libcoap branch March 11, 2021 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants