Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.graspy: rename to python3Packages.graspologic #99183

Merged
merged 1 commit into from Oct 25, 2020
Merged

python3Packages.graspy: rename to python3Packages.graspologic #99183

merged 1 commit into from Oct 25, 2020

Conversation

bcdarwin
Copy link
Member

neurodata/graspy has merged with microsoft/topologic and now redirects to microsoft/graspologic.

There hasn't been a new release since the merger, so this is only a metadata change (note the source hash is the same).

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bcdarwin bcdarwin changed the title graspy: rename to graspologic python3Packages.graspy: rename to python3Packages.graspologic Sep 30, 2020
@jonringer
Copy link
Contributor

@FRidh do you care about having an alias pointing from the old to the new? I don't really mind. Branch-off has already occurred

@FRidh FRidh merged commit 8e17389 into NixOS:master Oct 25, 2020
@FRidh
Copy link
Member

FRidh commented Oct 25, 2020

I typically prefer not to have aliases, which is a bit against the general rule I think.

@bcdarwin bcdarwin deleted the graspy-to-graspologic branch October 25, 2020 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bcdarwin @jonringer @FRidh