Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/moodle: add missing PHP module #99163

Merged
1 commit merged into from Oct 3, 2020
Merged

nixos/moodle: add missing PHP module #99163

1 commit merged into from Oct 3, 2020

Conversation

jmpunkt
Copy link
Contributor

@jmpunkt jmpunkt commented Sep 30, 2020

Motivation for this change

Without the filter extension the service moodle-init-start fails.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@aanderse
Copy link
Member

ping @Kloenk

@Kloenk
Copy link
Member

Kloenk commented Sep 30, 2020

On my system it works and succeds with the current nixpkgs master. Do you have any special config for which this is needed?

@jmpunkt
Copy link
Contributor Author

jmpunkt commented Sep 30, 2020

My local master is on a7f375d. Found this issue while scrolling through the ZHF for 20.09. The Hydra build for 20.09 fails on all architectures. It was possible for me to reproduce the same error also on the master branch. Adding the filter extensions solves the problem, which makes sense based on the error message.

@Kloenk
Copy link
Member

Kloenk commented Oct 3, 2020

This is also missing for h5p, so looks ready to merge to me

@ghost ghost merged commit 07988a0 into NixOS:master Oct 3, 2020
@aanderse
Copy link
Member

aanderse commented Oct 3, 2020

Make sure to file a backport and mark it as ZHF!

@jmpunkt jmpunkt mentioned this pull request Oct 3, 2020
Merged
10 tasks
@jmpunkt jmpunkt deleted the moodle--missing-extension branch October 3, 2020 13:50
ghost pushed a commit that referenced this pull request Oct 3, 2020
@jmpunkt
nixos/moodle: add missing PHP module (#99476)
00d578a 
ZHF: #97479

Backport of #99163
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jmpunkt @aanderse @Kloenk @Janik-Haag