Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mariadb-connector-c: multiple outputs #97672

Merged
merged 12 commits into from Sep 15, 2020
Merged

mariadb-connector-c: multiple outputs #97672

merged 12 commits into from Sep 15, 2020

Conversation

ttuegel
Copy link
Member

@ttuegel ttuegel commented Sep 10, 2020 •
edited

Motivation for this change

Use multiple outputs for mariadb-connector-c to reduce closure size.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ttuegel ttuegel added the 9.needs: port to stable A PR needs a backport to the stable release. label Sep 10, 2020
@ttuegel ttuegel marked this pull request as draft September 10, 2020 15:28
@aanderse
Copy link
Member

ping @Izorkin as an FYI

@Izorkin
Copy link
Contributor

Izorkin commented Sep 11, 2020

Needing add this patch - #71860 ? Also reduces closure size, but need to be checked other packages.

@ttuegel
Copy link
Member Author

ttuegel commented Sep 11, 2020

Needing add this patch - #71860 ? Also reduces closure size, but need to be checked other packages.

No, that patch won't have any practical effect with multiple outputs enabled.

@ttuegel ttuegel force-pushed the mariadb-connector-c-multiple-outputs branch from 3728078 to aee6df1 Compare September 12, 2020 11:58
@ttuegel ttuegel marked this pull request as ready for review September 12, 2020 11:59
@ttuegel ttuegel force-pushed the mariadb-connector-c-multiple-outputs branch from aee6df1 to f41b7f7 Compare September 12, 2020 16:37
@ofborg ofborg bot removed the 6.topic: python label Sep 12, 2020
@ttuegel ttuegel merged commit c0825dd into NixOS:staging Sep 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: closure-size 6.topic: lua 8.has: clean-up 9.needs: port to stable A PR needs a backport to the stable release. 10.rebuild-darwin: 501-1000 10.rebuild-darwin: 501+ 10.rebuild-linux: 501+ 10.rebuild-linux: 1001-2500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ttuegel @aanderse @Izorkin