Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LDAP support continued (with missing packages & tests) #805

Merged
merged 7 commits into from Sep 11, 2020

Conversation

andir
Copy link
Member

@andir andir commented Sep 10, 2020

This is picking up the work from @ajs124 in #684.

The main difference to the previous PR is that I started writing tests for it (while I was trying to figure out if it is working). That work required adding the missing perl packages which I'm also adding to NixPkgs in NixOS/nixpkgs#97673. For the meantime they should probably be kept in here until NixOS 21.03 is released.

As written in the original PR this still has the hard coded hydra_ prefix for all the roles that are currently supported by hydra. IMO extending that is out of scope for an initial implementation. If someone really needs different names and/or has multiple hydra setups with different permissions for the same person they can still have a different OU's in their LDAP and filter accordingly.

ajs124 and others added 6 commits September 9, 2020 13:00
Nixpkgs doesn't currently provide these required packages. In order to
use this feature without waiting for a newer release of NixOS/Nixpkgs
thes have been packages inline.
In this newly added test an OpenLDAP server will provide one user
(called `user`) and it will be attempted to login as that said user.
Also logging in with any other password must fail.
@andir
Copy link
Member Author

andir commented Sep 12, 2020

I just deployed this to my private hydra instance and apparently this PR broke non-LDAP logins. I'll be looking into that today or latest on monday.

@ajs124
Copy link
Member

ajs124 commented Sep 12, 2020

Oops. I could have sworn I tested that… That's what this was supposed to do…

@andir
Copy link
Member Author

andir commented Sep 12, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants