perlPackages: init Catalyst::Authentication::Store::LDAP at 1.016 (and dependencies) #97673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d dependencies) This is part of and effort of adding LDAP support to hydra.
andir
force-pushed
the
add-perl-catalyst-ldap
branch
from
f4c93db
to
24aedc9
Compare
ofborg
bot
added
8.has: package (new)
10.rebuild-darwin: 1-10
10.rebuild-linux: 1-10
labels
|
@GrahamcOfBorg build perlPackages.CatalystAuthenticationStoreLDAP perldevelPackages.CatalystAuthenticationStoreLDAP |
stigtsp
requested changes
Sep 11, 2020
There was a problem hiding this comment.
Hi there, just a few things:
The commit message should be consistent with CONTRIBUTING.md, like perlPackages.CatalystAuthenticationStoreLDAP: init at 1.016
| sha256 = "0cm399vxqqf05cjgs1j5v3sk4qc6nmws5nfhf52qvpbwc4m82mq8"; | ||
| }; | ||
| propagatedBuildInputs = [ NetLDAP CatalystPluginAuthentication ClassAccessorFast ]; | ||
| buildInputs = [ TestMore TestMockObject TestException NetLDAPServerTest ]; |
There was a problem hiding this comment.
Suggested change
| buildInputs = [ TestMore TestMockObject TestException NetLDAPServerTest ]; | |
| buildInputs = [ TestMockObject TestException NetLDAPServerTest ]; |
NetLDAPServerTest includes TestMore
| url = "mirror://cpan/authors/id/K/KA/KARMAN/Net-LDAP-Server-Test-0.22.tar.gz"; | ||
| sha256 = "13idip7jky92v4adw60jn2gcc3zf339gsdqlnc9nnvqzbxxp285i"; | ||
| }; | ||
| propagatedBuildInputs = [ NetLDAP NetLDAPServer TestMore DataDump NetLDAPSID ]; |
There was a problem hiding this comment.
Suggested change
| propagatedBuildInputs = [ NetLDAP NetLDAPServer TestMore DataDump NetLDAPSID ]; | |
| propagatedBuildInputs = [ NetLDAPServer TestMore DataDump NetLDAPSID ]; |
NetLDAPServer includes NetLDAP
stigtsp
approved these changes
Nov 12, 2020
There was a problem hiding this comment.
LGTM apart from minor nitpics
Result of nixpkgs-review pr 97673 1
8 packages built:
- perl530Packages.CatalystAuthenticationStoreLDAP
- perl530Packages.NetLDAPSID
- perl530Packages.NetLDAPServer
- perl530Packages.NetLDAPServerTest
- perl532Packages.CatalystAuthenticationStoreLDAP
- perl532Packages.NetLDAPSID
- perl532Packages.NetLDAPServer
- perl532Packages.NetLDAPServerTest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This is part of and effort of adding LDAP support to hydra: NixOS/hydra#805
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)