re-design: MVP all (most) pages #522
Conversation
This is only useful for small pages, but still.
The unsemantic columns allows us to plow faster through the bootstrap layouts and make them MVPs.
Not the prettiest, but MVP for now.
Probably final.
The tabs aren't implemented yet
samueldr
force-pushed
the
feature/2020-r/mvp-allpages
branch
from
087b276 to
ed37189
Compare
|
the box don't really fit the rest of the design. it's ok for now, but we should ask the designer for a proper design of it
https://raw.githubusercontent.com/NixOS/rfcs/master/rfcs/0036-review-process.png needs a preview effect on the gov. page. it opens as new page now i wouldn't expect the whole banner to be clickable, only the underlined text. but might be ok
|
|
I was actually more concerned about making the tabs work as expected (e.g. reload or anchor link opens the right tab) than the looks. I kind of forgot to make them look "better", got so used to seeing it while working on that that it didn't bother me that much anymore :). Depending on what is done for the downloads page, which will be closer to the actual redesign, the tabs looks may change. |
Subject to review: Any page where the equivalent
.ttsource file has been edited. Any of the pages untouched, or discussed in the next section are not to be tested or reviewed yet.We're left with:
guidesThe learn page needs a bit more care than the basic MVP, but as stated in the last meeting, this'll be done with minimal implementation, not the full blown re-design
The download page will need even more care than the basic MVP, compared to learn. But still, not the full blown re-design yet.
The manuals should be almost ready, but I know there were some things to review.
(new from merge with master) guides will need a bit more work...Open questions