Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-design: MVP all (most) pages #522

Merged
merged 17 commits into from Sep 14, 2020

Conversation

samueldr
Copy link
Member

@samueldr samueldr commented Sep 9, 2020

Subject to review: Any page where the equivalent .tt source file has been edited. Any of the pages untouched, or discussed in the next section are not to be tested or reviewed yet.


We're left with:

  • learn
  • download
  • manuals
  • guides

The learn page needs a bit more care than the basic MVP, but as stated in the last meeting, this'll be done with minimal implementation, not the full blown re-design

The download page will need even more care than the basic MVP, compared to learn. But still, not the full blown re-design yet.

The manuals should be almost ready, but I know there were some things to review.

(new from merge with master) guides will need a bit more work...


Open questions

  • Tabs styling... see the donate page. This is extremely an MVP.

@samueldr samueldr added the design About the design refresh work label Sep 9, 2020
@github-actions
Copy link
Contributor

@davidak
Copy link
Member

davidak commented Sep 10, 2020

the box don't really fit the rest of the design. it's ok for now, but we should ask the designer for a proper design of it

Screenshot from 2020-09-10 22-12-03

https://raw.githubusercontent.com/NixOS/rfcs/master/rfcs/0036-review-process.png needs a preview effect on the gov. page. it opens as new page now

i wouldn't expect the whole banner to be clickable, only the underlined text. but might be ok

Screenshot from 2020-09-10 22-19-11

Copy link
Member

@davidak davidak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@github-actions
Copy link
Contributor

@samueldr
Copy link
Member Author

samueldr commented Sep 10, 2020

I was actually more concerned about making the tabs work as expected (e.g. reload or anchor link opens the right tab) than the looks. I kind of forgot to make them look "better", got so used to seeing it while working on that that it didn't bother me that much anymore :).

Depending on what is done for the downloads page, which will be closer to the actual redesign, the tabs looks may change.

@samueldr samueldr merged commit d1bf2d6 into feature/2020-redesign Sep 14, 2020
@samueldr samueldr deleted the feature/2020-r/mvp-allpages branch September 14, 2020 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design About the design refresh work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants