Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.pyfakefs: disable on python 2.7 #97619

Merged
merged 1 commit into from Sep 10, 2020
Merged

python3Packages.pyfakefs: disable on python 2.7 #97619

merged 1 commit into from Sep 10, 2020

Conversation

drewrisinger
Copy link
Contributor

Motivation for this change

Disable pythonPackages.pyfakefs for unsupported python versions.

ZHF: #97479

Update meta & enable tests.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@drewrisinger
python3Packages.pyfakefs: disable on py2.7
a9d7ea7 
* No longer supports python < 3.5, so disabled.
* Enables tests that were disabled due to bugs.
* Add changelog
@drewrisinger drewrisinger added the 9.needs: port to stable A PR needs a backport to the stable release. label Sep 10, 2020
jonringer
jonringer approved these changes Sep 10, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 97619 1

9 packages built:
  • python37Packages.aws-adfs
  • python37Packages.fido2
  • python37Packages.pyfakefs
  • python37Packages.pyu2f
  • python37Packages.qasm2image
  • python37Packages.qiskit
  • python37Packages.qiskit-aqua
  • python37Packages.qiskit-ignis
  • python37Packages.solo-python

@jonringer jonringer merged commit 9fae7b2 into NixOS:master Sep 10, 2020
@drewrisinger drewrisinger deleted the zhf/pyfakefs branch September 10, 2020 03:18
@drewrisinger drewrisinger mentioned this pull request Sep 10, 2020
Merged
10 tasks
jonringer
jonringer approved these changes Sep 10, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 97619 1

9 packages built:
  • python37Packages.aws-adfs
  • python37Packages.fido2
  • python37Packages.pyfakefs
  • python37Packages.pyu2f
  • python37Packages.qasm2image
  • python37Packages.qiskit
  • python37Packages.qiskit-aqua
  • python37Packages.qiskit-ignis
  • python37Packages.solo-python

@jonringer
Copy link
Contributor

oops, should have refreshed page

@veprbl veprbl added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Sep 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@gebner gebner Awaiting requested review from gebner

Assignees
No one assigned
Labels
8.has: port to stable A PR already has a backport to the stable release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@drewrisinger @jonringer @veprbl