Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/nfs: fix permissions #97656

Closed
wants to merge 1 commit into from
Closed

nixos/nfs: fix permissions #97656

wants to merge 1 commit into from

Conversation

peterhoeg
Copy link
Member

Motivation for this change

Further to #96844

Fixes #97582

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@peterhoeg
Copy link
Member Author

@GrahamcOfBorg test nfs

@vcunat
Copy link
Member

vcunat commented Sep 10, 2020

@GrahamcOfBorg test nfs3.simple nfs4.kerberos nfs4.simple

vcunat added a commit that referenced this pull request Sep 10, 2020
This reverts commit 42eebd7, reversing
changes made to b169bfc.

This breaks nfs3.simple test and even current PR #97656 wouldn't fix it.
Therefore let's revert for now to unblock the channels.
@vcunat
Copy link
Member

vcunat commented Sep 10, 2020

nfs3.simple test still doesn't work for me, so I reverted that change in 538e558.

@stale
Copy link

stale bot commented Apr 7, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Apr 7, 2021
@peterhoeg
Copy link
Member Author

Closing for now. First proper step towards fixing this is in #177601

@peterhoeg peterhoeg closed this Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tests.nfs3.simple fails, blocking nixos-unstable
3 participants