-
-
Notifications
You must be signed in to change notification settings - Fork 15.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python3Packages.pytest-timeout: 1.3.3 -> 1.4.2 #97621
Conversation
* Update version * switch to pytestCheckHook * Update meta: hompage & changelog * explicit runtime dependency on pytest Based on work by @jpgu-epam in NixOS#97527.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(This could just be my server) but I'm seeing a lot of regressions in dask:
builder for '/nix/store/ly69plyw6s4j49f1pcpqi0pjk6g7kq22-python3.8-dask-2.22.0.drv' failed with exit code 1; last 10 log lines:
Can't please 'em all
XFAIL dask/tests/test_order.py::test_run_smaller_sections[abcde]
This is challenging to do precisely
XFAIL dask/tests/test_order.py::test_run_smaller_sections[edcba]
This is challenging to do precisely
XFAIL dask/dataframe/tests/test_groupby.py::test_apply_or_transform_shuffle_multilevel[<lambda>0-<lambda>5]
condition: NotImplemented
XFAIL dask/dataframe/tests/test_groupby.py::test_apply_or_transform_shuffle_multilevel[<lambda>1-<lambda>5]
condition: NotImplemented
= 20 failed, 6613 passed, 778 skipped, 41 xfailed, 1 xpassed, 6 warnings in 1003.22s (0:16:43) =
cannot build derivation '/nix/store/q0bnhfwq2vd2yi2v736cqvfh346zrkyv-python3.8-dask-glm-0.2.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/j1xpgcapz5haymf5w0aaqwpb5bnkd5b2-python3.8-distributed-2.23.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/0fw06wd96180hp64z2fc2wnjzrxi7rl4-python3.8-intake-0.6.0.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/z6fq9jd6grxqa4km12yzr7y0irpnx0in-python3.8-pyFFTW-0.12.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/bsa9rjixj1lr20r7pc6cscrkxf1a5b72-python3.8-scikit-image-0.17.2.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/dipqlnl76x59vawihnpj7fnvjxj7q8kx-python3.8-sparse-0.10.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/jch4x0mad2spy37cbx4yn8x897f6fg0f-caffe-1.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/gsvq0hpj79majscyq0332vphazwak8y2-python3.8-PIMS-0.5.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/1wrgv93cwf8gs4hf3ra7f14sxxsj1n1v-python3.8-aplpy-2.0.3.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/y40w3g918v2a9pmbxgpyz3f03qhf22pc-python3.8-batchgenerators-0.20.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/3sdkxivxwgm4hnfrxasjf2i2pc691a23-python3.8-clifford-1.3.1.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/l6h7v3zk9lz3kppr80zac9byln9cf6lc-python3.8-dask-gateway-0.8.0.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/iij6wrshi9j5jm2yb0ys7izv7w3rzdyr-python3.8-dask-jobqueue-0.7.1.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/vrghxhwgz2scc6v0ysy8abnfgfx3pfhg-python3.8-dask-ml-1.6.0.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/7czbxi1nprxqs38s8bx6g1dprf0rnrhn-python3.8-dask-mpi-2.21.0.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/3zyqw9i2r7amn64g4yhbw325cmzs88ki-python3.8-dask-xgboost-0.1.11.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/zw0prwj1iyq5drh3flk81bmrr18wrg2i-python3.8-datashader-0.11.1.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/hlry4i77cychhmb6ry443095fwr7pcif-python3.8-glymur-0.8.18.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/kfm6r7aka4f0fpvi2g6s2ncrrvaxrjh8-python3.8-image-match-1.1.2.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/i3f9jgk7cw9caf3v4jjn7bx0ia21nz5z-python3.8-streamz-0.5.5.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/i9cfp3fa03cyg0nzzminyar8xz1jxh1z-python3.8-stumpy-1.4.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/zqsynfylbrpcziw2a3kf0pgv2hcqslfh-python3.8-tensorly-0.4.5.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/v17p7j688bsskmnb1sr3n4vz5ydvbaik-python3.8-dask-image-0.3.0.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/cizlpcsm63hh55diaa55m0vnm271n328-python3.8-spectral-cube-0.4.5.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/9nf3gkbpgq97g3kqp5iiyd3rfxb8r3b2-python3.8-sunpy-1.0.6.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/qymbl8cb9avmiy5bkp992qdyxaid1dh6-python3.8-imagecorruptions-1.1.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/yb7l9bkvv7waf46q65ig0wv8r6in6fpa-python3.8-stytra-0.8.34.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/8yba2bpqmi1jwcc790lcw2iza28k6x9w-python3.8-imgaug-0.4.0.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/3ppjs02n5l9mmqi4izyrv7d8hm34n0b5-ffmpeg-full-4.3.1.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/rdsx2r8lwq481brdsxwxw84dk4nbnsxp-python3.7-pyglet-1.4.2.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/5n3915qp26zks8x9x1sq6d1pylf2lis5-python3.7-gym-0.17.2.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/yh4l7a0742ql4ajcj8ix502i6cc4jzaa-python3.7-rl-coach-1.0.1.drv': 3 dependencies couldn't be built
I don't get the same error, but my dask derivation must be different than yours:
|
must have merged at a different point in master, not sure, I'll investigate later |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great, thanks for refactoring
@jonringer Do you think that may still be an issue? I would expect this to be a harmless update, but want to make sure we aren't causing any regressions before merging. |
@GrahamcOfBorg build python3Packages.dask |
I've had a lot of issues reviewing dask, their test framework usually fails if i give it > ~10 cores. I give it 32. Which is weird for a framework which is focused on distributed compute. |
if ofborg is able to build it, then I say we go ahead and merge |
was able to build dask locally with doign:
|
Motivation for this change
Based on work by @jpgu-epam in #97527 (supersedes that PR's pytest-timeout due to more tests enabled & updated meta)
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)