Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

magma: use cmake rules #97703

Closed

Conversation

matthewbauer
Copy link
Member

It looks like the default CMake install phase now works. All of the
install things are there, so let's just use that.

It looks like the default CMake install phase now works. All of the
install things are there, so let's just use that.
@tbenst
Copy link
Contributor

tbenst commented Sep 11, 2020

@mathewbauer nice! Glad to see things simplified :). Just wanted to check that libmagma_sparse still built? Used to need to specify manually, but seems like the default may have changed.

@matthewbauer
Copy link
Member Author

@mathewbauer nice! Glad to see things simplified :). Just wanted to check that libmagma_sparse still built? Used to need to specify manually, but seems like the default may have changed.

Yes - libmagma.so & libmagma_sparse.so are built.

sed -e s:@MAGMA_REQUIRED@:: \
> $out/lib/pkgconfig/magma.pc
'';
enableParallelBuilding = true;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Enabled by default for cmake builds IIRC.

@stale
Copy link

stale bot commented Jun 26, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 26, 2021
@Artturin
Copy link
Member

Artturin commented Feb 2, 2023

Rebase and reopen if still interested

@Artturin Artturin closed this Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants