Fix guides titles (<title>) #524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The title was using what amounted to: echo '[% $title %]' > file.tt Which put the literal `$title` perl variable, which in Template Toolkit, an undefined variable is equivalent to an empty string. This made the <title /> of the page be "NixOS - Guides - ". This fixes that by using the better `printf` building for building strings to print. Additionally we can drop the empty echoes and use `\n` as printf honours them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The title was using what amounted to:
Which put the literal
$titleperl variable, which in Template Toolkit,an undefined variable is equivalent to an empty string.
This made the <title /> of the page be "NixOS - Guides - ".
This fixes that by using the better
printfbuilding for buildingstrings to print.
Additionally we can drop the empty echoes and use
\nas printf honoursthem.
In addition, mark the script as an input of those generated files.