opencascade: enable macOS build and add features #97661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
6.topic: darwin
veprbl
reviewed
Sep 10, 2020
pkgs/development/libraries/opencascade/opencascade-oce-vtk.patch
Outdated
Show resolved
Hide resolved
hannesweisbach
force-pushed
the
opencascade-oce
branch
from
974b956
to
597b857
Compare
hannesweisbach
force-pushed
the
opencascade-oce
branch
2 times, most recently
from
31193cf
to
a651029
Compare
veprbl
approved these changes
Sep 17, 2020
hannesweisbach
force-pushed
the
opencascade-oce
branch
from
a651029
to
0fcee10
Compare
Thanks.
Done. |
veprbl
reviewed
Sep 19, 2020
|
LGTM (aside from the fetchpatch failure).
I'm not 100% sure I understand you. |
|
@gebner I do, I wasn't sure which opencascade to choose so I made it so it compiled and worked with both. Default is OCCT though. Thanks for letting me know OCCT is preferred though. OCE might still be used for other software though. |
enable/fix macOS build and add options for TBB and GL2PS dependencies VTK integration needed a patch because implicit conversions in initializer lists are an error in C++11, which is the default in clang 7 used by nix.
hannesweisbach
force-pushed
the
opencascade-oce
branch
from
0fcee10
to
80a6743
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
enable/fix macOS build and add options for TBB and GL2PS dependencies
VTK integration needed a patch because implicit conversions in initializer
lists are an error in C++11, which is the default in clang 7 used by nix.
Motivation for this change
I'm currently working on KiCad for macOS in nix. KiCad depends on Opencascade. Opencascade-occt works fine, but opencascade (OCE) was only enabled to build on Linux. I've enabled the build on macOS and it "works for me" on macOS 10.15.6, both building opencascade and using it as dependency in KiCad.
VTK-integration of opencascade threw 2 errors for me, both had to do with (implicit) conversions happening in initializer lists, which is illegal in C++11 (or 14?), which is the default in clang-7 (the compiler used by my nix). Upstream opencascade seemed to not have fixed that yet, but does also not include a specific C++ standard to compile with. I assumed this is a bug though and included a patch to make both those implicit conversion explicit, so it compiles fine. I'm not sure if this is the correct thing to do here, though, but, again it seems to work for me. I've enabled this patch only for macOS, since this seems to be not an issue on Linux for some reason, again, I'm not sure why.
I've also added options to build with TBB as parallelization/multithreading library, as well as GL2PS, which is an optional dependency of opencascade. Scripts to build KiCad had these options for opencascade enabled, which is why I added those options. The options are defaulted to
false, to be backward compatible.Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)