Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exiv2: re-enable split outputs #97705

Merged
merged 1 commit into from Sep 11, 2020
Merged

exiv2: re-enable split outputs #97705

merged 1 commit into from Sep 11, 2020

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Sep 10, 2020 •
edited

Motivation for this change

Needs an extra patch to fix CMake config.

This reverts commit f8f840f.

Fixes: #97161 (comment)
Upstream: Exiv2/exiv2#1294

Things done
  • Checked that result-dev/lib/cmake/exiv2/exiv2Config.cmake uses absolute path for INTERFACE_INCLUDE_DIRECTORIES
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jtojnar
exiv2: re-enable split outputs
8060ecb 
Needs an extra patch to fix CMake config.

This reverts commit f8f840f.
@timokau
Copy link
Member

timokau commented Sep 11, 2020

@GrahamcOfBorg build digikam

@timokau timokau merged commit 5e0112b into NixOS:master Sep 11, 2020
@jtojnar jtojnar deleted the exiv2-split-again branch September 11, 2020 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timokau timokau timokau approved these changes

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jtojnar @timokau @worldofpeace