Merge ImageData::data_union into ImageData::data #25474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Sep 10, 2020
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2379653
branch
6 times, most recently
from
414c3d2
to
f49bc12
Compare
The ImageData interface has two data entries: data(array of uint8) and data_union(could be array of uint8, float16 or float32). In this cl, I deleted data and rename data_union to data. This cl prepares canvas to work with more data types, which will help us to enable canvas to work with p3 and rec2020. Note that some part of the code works with uint8 only, i have put a TODO for each of the occurrence. I will address them in the next cl. Bug: 1115317 Change-Id: Ia7f203e627547eceb6da479522b3130bc6eaef12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379653 Reviewed-by: Fernando Serboncini <fserb@chromium.org> Reviewed-by: Jeremy Roman <jbroman@chromium.org> Reviewed-by: Yi Xu <yiyix@chromium.org> Reviewed-by: Juanmi Huertas <juanmihd@chromium.org> Reviewed-by: ccameron <ccameron@chromium.org> Commit-Queue: Yi Xu <yiyix@chromium.org> Cr-Commit-Position: refs/heads/master@{#807179}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2379653
branch
from
f49bc12
to
90332a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ImageData interface has two data entries: data(array of uint8) and
data_union(could be array of uint8, float16 or float32). In this cl, I
deleted data and rename data_union to data. This cl prepares canvas to
work with more data types, which will help us to enable canvas to work
with p3 and rec2020.
Note that some part of the code works with uint8 only, i have put a TODO
for each of the occurrence. I will address them in the next cl.
Bug: 1115317
Change-Id: Ia7f203e627547eceb6da479522b3130bc6eaef12
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379653
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Yi Xu <yiyix@chromium.org>
Reviewed-by: Juanmi Huertas <juanmihd@chromium.org>
Reviewed-by: ccameron <ccameron@chromium.org>
Commit-Queue: Yi Xu <yiyix@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807179}