Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nagios: fix build #97649

Merged
merged 1 commit into from Sep 10, 2020
Merged

nagios: fix build #97649

merged 1 commit into from Sep 10, 2020

Conversation

immae
Copy link
Contributor

@immae immae commented Sep 10, 2020

Motivation for this change

The compiler complains about dl* functions missing, this PR adds the necessary flag to pass to gcc to make it build correctly.

ZHF: #97479

ping @NixOS/nixos-release-managers

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@immae
Copy link
Contributor Author

immae commented Sep 10, 2020

@thoughtpolice @relrod I cannot ping @NixOS/nixos-release-managers but since this concerns nagios you might want to have a look as you’re declared as maintainer here

@aanderse
Copy link
Member

If memory serves correct @thoughtpolice and @relrod don't maintain this package anymore and should probably be removed from that list. I believe @symphorien maintains nagios on NixOS now. @immae if you use nagios on NixOS would you be interested in maintaining, or is this just for ZHF?

The compiler complains about dl* function missing, this commit adds the
necessary flag to pass to gcc to make it build correctly
@immae
Copy link
Contributor Author

immae commented Sep 10, 2020

If memory serves correct @thoughtpolice and @relrod don't maintain this package anymore and should probably be removed from that list. I believe @symphorien maintains nagios on NixOS now. @immae if you use nagios on NixOS would you be interested in maintaining, or is this just for ZHF?

@aanderse I did the fix in context of ZHF. I’m not strictly a user of nagios but I’m a user of naemon which is a fork of it, so I can maintain it in parallel to naemon (I’m following the development of both anyway). I added myself to the maintainer’s list

@ryantm
Copy link
Member

ryantm commented Sep 10, 2020

Result of nixpkgs-review pr 97649 1

1 package built:
- nagios

@ryantm ryantm merged commit 6d96b3c into NixOS:master Sep 10, 2020
@immae immae mentioned this pull request Sep 10, 2020
10 tasks
@immae
Copy link
Contributor Author

immae commented Sep 10, 2020

Backport to 20.09: #97664

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants