Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI failures for Python <3.6 #72

Closed
mkurc-ant opened this issue Sep 10, 2020 · 4 comments
Closed

CI failures for Python <3.6 #72

mkurc-ant opened this issue Sep 10, 2020 · 4 comments

Comments

@mkurc-ant
Copy link
Contributor

There are CI failures for Python version <3.6. I've verified them with the #32 PR:

Python 2.7 (I guess we are actually not interested in Python 2):

py27 run-test: commands[2] | flake8 .
./v2x/vlog_to_pbtype.py:154:20: E999 SyntaxError: invalid syntax
./v2x/mux_gen.py:173:25: E999 SyntaxError: invalid syntax
./v2x/yosys/json.py:281:35: E999 SyntaxError: invalid syntax

Python 3.4 (Incompatible lxml):

    ERROR: This lxml version requires Python 2.7, 3.5 or later.

Python 3.5 - Here are a few test failures for V2X itself. I guess that it has to do that Python 3.6 introduces some data order preservation mechanisms not present in 3.5. Fixing that requires more thorough investigation and I don't think that it is the highest priority as we mostly use Python 3.6/3.7.
@mkurc-ant
Copy link
Contributor Author

Failures for 3.5 have been fixed in #76

@mithro
Copy link
Collaborator

mithro commented Sep 11, 2020

Let's definitely drop 2.7 and 3.4

We can probably drop 3.5 too

@mkurc-ant
Copy link
Contributor Author

With #76 2.7 and 3.4 are disabled in CI. 3.5 is still enabled as I've managed to fix issues with maintaining item order. So shall I disable that one too?

@mkurc-ant
Copy link
Contributor Author

CI passes for Python 3.5, 3.6, and 3.7. Other versions are dropped. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mithro @mkurc-ant