foundationdb: add branch 6.2 #97683
foundationdb: add branch 6.2 #97683
Conversation
foundationdb: fix, removed trailing whitespace
foundationdb: fix incorrect maintainer
|
|
||
| meta = with stdenv.lib; { | ||
| description = "Open source, distributed, transactional key-value store"; | ||
| homepage = https://www.foundationdb.org; |
There was a problem hiding this comment.
I think this should be quoted, as direct url syntax is deprecated
| @@ -11,6 +11,10 @@ let | |||
| gccStdenv = gccStdenv; | |||
| llvmPackages = llvmPackages; | |||
| }); | |||
| cmakeBuild62 = import ./cmake62.nix (args // { | |||
There was a problem hiding this comment.
The reason for the split cmake62 seems to be the change of libressl->openssl? I think it might be better for maintenance to keep one cmake.nix file and pass an option for which ssl package/declarations.
| +# dirty hack for nixos to stop cmake complaining about version mismatch | ||
| execute_process( | ||
| - COMMAND ${CMAKE_CURRENT_SOURCE_DIR}/build/get_version.sh ${CMAKE_CURRENT_SOURCE_DIR}/versions.target | ||
| + COMMAND bash "-c" "cat ${CMAKE_CURRENT_SOURCE_DIR}/versions.target| grep '<Version>' | sed -e 's,^[^>]*>,,' -e 's,<.*,,'" |
There was a problem hiding this comment.
It looks to me like you are inlining the scripts to avoid broken shebangs. It looks like vsmake was using patchShebangs so I'm not sure if this was broken in 6.1, but only fatal now?
I think patchShebangs should be used if possible or a comment as to this is what it is doing would help for people integrating future versions.
| # ------------------------------------------------------ | ||
|
|
||
| foundationdb62 = cmakeBuild62 { | ||
| version = "6.2.25"; |
There was a problem hiding this comment.
I think it should be freshened to the latest.
|
ping @thoughtpolice |
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
|
Is this otherwise still working (are you using it)? @SuperSandro2000 @lostnet |
stale
bot
removed
the
2.status: stale
| for x in bindings/c/CMakeLists.txt fdbserver/CMakeLists.txt fdbmonitor/CMakeLists.txt fdbbackup/CMakeLists.txt fdbcli/CMakeLists.txt; do | ||
| substituteInPlace $x --replace 'fdb_install' 'install' | ||
| done |
There was a problem hiding this comment.
| for x in bindings/c/CMakeLists.txt fdbserver/CMakeLists.txt fdbmonitor/CMakeLists.txt fdbbackup/CMakeLists.txt fdbcli/CMakeLists.txt; do | |
| substituteInPlace $x --replace 'fdb_install' 'install' | |
| done | |
| for x in bindings/c/CMakeLists.txt fdbserver/CMakeLists.txt fdbmonitor/CMakeLists.txt fdbbackup/CMakeLists.txt fdbcli/CMakeLists.txt; do | |
| substituteInPlace $x --replace 'fdb_install' 'install' | |
| done |
| cmakeFlags = | ||
| [ "-DCMAKE_BUILD_TYPE=Release" | ||
| (lib.optionalString officialRelease "-DFDB_RELEASE=TRUE") | ||
|
|
||
| # FIXME: why can't openssl be found automatically? |
There was a problem hiding this comment.
| cmakeFlags = | |
| [ "-DCMAKE_BUILD_TYPE=Release" | |
| (lib.optionalString officialRelease "-DFDB_RELEASE=TRUE") | |
| # FIXME: why can't openssl be found automatically? | |
| cmakeFlags = [ | |
| "-DCMAKE_BUILD_TYPE=Release" | |
| (lib.optionalString officialRelease "-DFDB_RELEASE=TRUE") | |
| # FIXME: why can't openssl be found automatically? |
and so on
| tests = with builtins; | ||
| builtins.replaceStrings [ "\n" ] [ " " ] (lib.fileContents ./test-list.txt); |
There was a problem hiding this comment.
| tests = with builtins; | |
| builtins.replaceStrings [ "\n" ] [ " " ] (lib.fileContents ./test-list.txt); | |
| tests = builtins.replaceStrings [ "\n" ] [ " " ] (lib.fileContents ./test-list.txt); |
stale
bot
added
the
2.status: stale
Motivation for this change
A new branch of Foundationdb exists for quite a long time, current branch is 6.2.25, so this PR adds support for it.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)