Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] nixos/dmidecode: added recommended patches #97686

Closed
wants to merge 2 commits into from
Closed

[20.09] nixos/dmidecode: added recommended patches #97686

wants to merge 2 commits into from

Conversation

superherointj
Copy link
Contributor

Motivation for this change

In ARM libvirtd is broken because of a bug in 'dmidecode'. This patch applies the upstream recommended patches for dmidecode and fixes issue #97544 .

Backporting #97614 to nixos-20.09

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@superherointj superherointj changed the title nixos/dmidecode: added recommended patches [20.09] nixos/dmidecode: added recommended patches Sep 10, 2020
@superherointj
nixos/dmidecode: added recommended patches
78c9582 
Co-authored-by: Jörg Thalheim <Mic92@users.noreply.github.com>
(cherry picked from commit d284d32)
zowoq
zowoq requested changes Sep 10, 2020
View reviewed changes
Copy link
Contributor

@zowoq zowoq left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Base branch should be release-20.09, not nixos-20.09 and please remove the unrelated commit.

Also please follow CONTRIBUTING.md#backporting-changes and use git cherry-pick -x.

@worldofpeace worldofpeace changed the base branch from nixos-20.09 to release-20.09 September 11, 2020 01:55
@superherointj superherointj deleted the nixos-20.09 branch September 11, 2020 09:35
@superherointj
Copy link
Contributor Author

I was not able to recover from my mistakes in this pull request. So I had done another one: #97764
This time, hopefully, right. Sorry for the noise, bothering people, etc. I get it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zowoq zowoq zowoq requested changes

@Mic92 Mic92 Awaiting requested review from Mic92 Mic92 is a code owner

Assignees
No one assigned
Labels
6.topic: policy discussion 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@superherointj @zowoq