Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inkscape: 1.0 → 1.0.1 #97690

Merged
merged 2 commits into from Sep 12, 2020
Merged

inkscape: 1.0 → 1.0.1 #97690

merged 2 commits into from Sep 12, 2020

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Sep 10, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: TeX Issues regarding texlive and TeX in general 8.has: documentation 8.has: clean-up 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 labels Sep 10, 2020
@jtojnar
Copy link
Contributor Author

jtojnar commented Sep 12, 2020

@GrahamcOfBorg build arc-theme bibata-cursors bibata-extra-cursors bibata-cursors-translucent capitaine-cursors dblatex pantheon.elementary-icon-theme fim mate.mate-utils numix-cursor-theme pop-gtk-theme

@jtojnar jtojnar merged commit 607509a into NixOS:master Sep 12, 2020
@jtojnar jtojnar deleted the inkscape-1.0.1 branch September 12, 2020 14:30
@endocrimes
Copy link
Member

FWIW this change seems to have broken a few packages that were dependent on behaviour that seems to have changed between 0.x and 1.0 - at least twemoji-color-font on my system.

@jtojnar
Copy link
Contributor Author

jtojnar commented Sep 13, 2020

Looks like the pull request re-adding the legacy options was incomplete https://gitlab.com/inkscape/inkscape/-/merge_requests/2056

twemoji-color-font should be fixed by #97862.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romildo romildo Awaiting requested review from romildo

Assignees
No one assigned
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: TeX Issues regarding texlive and TeX in general 8.has: clean-up 8.has: documentation 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jtojnar @endocrimes