Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jwt-cli: fix build #97615

Merged
merged 1 commit into from Sep 10, 2020
Merged

jwt-cli: fix build #97615

merged 1 commit into from Sep 10, 2020

Conversation

wkral
Copy link
Contributor

@wkral wkral commented Sep 10, 2020

Motivation for this change

Fix build failure for jwt-cli when running tests, by patching with a proposed upstream fix.
ZHF: #97479

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@wkral
Copy link
Contributor Author

wkral commented Sep 10, 2020

Result of nixpkgs-review pr 97615 1

1 package built:
  • jwt-cli

@wkral wkral mentioned this pull request Sep 10, 2020
Merged
10 tasks
@ofborg ofborg bot requested a review from rycee September 10, 2020 03:01
@zowoq zowoq merged commit fb5a153 into NixOS:master Sep 10, 2020
@zowoq
Copy link
Contributor

zowoq commented Sep 10, 2020

Thanks!

Backported in 4a1d2f7.

@wkral wkral deleted the patch-jwt-cli branch September 10, 2020 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zowoq zowoq zowoq approved these changes

@rycee rycee Awaiting requested review from rycee

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wkral @zowoq