Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minecraft-server: 1.16.2 -> 1.16.3 #97674

Merged
merged 1 commit into from Sep 12, 2020
Merged

minecraft-server: 1.16.2 -> 1.16.3 #97674

merged 1 commit into from Sep 12, 2020

Conversation

Avaq
Copy link
Member

@Avaq Avaq commented Sep 10, 2020 •
edited

Motivation for this change

Desire to update my minecraft server

Things done
  • Ran ./update.sh
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Avaq
Copy link
Member Author

Avaq commented Sep 10, 2020

Again tested by deploying to my minecraft server and logging into it with a 1.16.3 client.

Jiehong
Jiehong approved these changes Sep 10, 2020
View reviewed changes
Copy link
Contributor

@Jiehong Jiehong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@Avaq
Copy link
Member Author

Avaq commented Sep 12, 2020

I'm not sure how to get this merged now. Last time (#95993) it was merged by @infinisil; Maybe they'll take a look again?:)

@infinisil infinisil merged commit 3558be4 into NixOS:master Sep 12, 2020
@Avaq Avaq deleted the avaq/minecraft-server branch October 4, 2020 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jiehong Jiehong Jiehong approved these changes

@costrouc costrouc Awaiting requested review from costrouc

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

@tomberek tomberek Awaiting requested review from tomberek

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Avaq @Jiehong @infinisil