Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

discord: 0.0.11 -> 0.0.12 #97694

Merged
merged 3 commits into from Sep 10, 2020
Merged

discord: 0.0.11 -> 0.0.12 #97694

merged 3 commits into from Sep 10, 2020

Conversation

TethysSvensson
Copy link
Contributor

I ran update-discord.sh. It also updated discord-ptb and discord-canary.

Motivation for this change

Discord does not work anymore because of the update.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@nyanloutre
Copy link
Member

30 seconds of difference ;D #97693

But you splited in different commits for each package

@TethysSvensson
Copy link
Contributor Author

30 seconds of difference ;D #97693

But you splited in different commits for each package

I knew I shouldn't have spent time writing a PR description ;)

@nyanloutre nyanloutre mentioned this pull request Sep 10, 2020
Closed
10 tasks
@TethysSvensson TethysSvensson mentioned this pull request Sep 10, 2020
Closed
10 tasks
@jonringer jonringer added the 9.needs: port to stable A PR needs a backport to the stable release. label Sep 10, 2020
jonringer
jonringer approved these changes Sep 10, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 97694 1

3 packages built:
- discord
- discord-canary
- discord-ptb

@jonringer jonringer merged commit 1937fd3 into NixOS:master Sep 10, 2020
@jonringer
Copy link
Contributor

please backport

@TethysSvensson TethysSvensson deleted the discord-update branch September 10, 2020 21:02
@TethysSvensson TethysSvensson mentioned this pull request Sep 10, 2020
Merged
10 tasks
@TethysSvensson
Copy link
Contributor Author

@jonringer: One for 20.03 is here #97708. Should I also do one for 20.09 or does it get it automatically from master?

@jonringer
Copy link
Contributor

it does not atomically get added after branch off, please do one for both :)

@TethysSvensson TethysSvensson mentioned this pull request Sep 10, 2020
Merged
10 tasks
@jonringer jonringer added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
8.has: port to stable A PR already has a backport to the stable release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@TethysSvensson @nyanloutre @jonringer