Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allegro: Add patch to fix fatal build error #97696

Merged
merged 1 commit into from Sep 12, 2020
Merged

allegro: Add patch to fix fatal build error #97696

merged 1 commit into from Sep 12, 2020

Conversation

WhittlesJr
Copy link
Contributor

Motivation for this change

Fixes #97579

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from 7c6f434c September 10, 2020 22:02
@pbogdan
Copy link
Member

pbogdan commented Sep 10, 2020

Was this not fixed with #97432?

@7c6f434c
Copy link
Member

@pbogdan Well, this fix is cleaner

@7c6f434c 7c6f434c merged commit b623628 into NixOS:master Sep 12, 2020
@pbogdan
Copy link
Member

pbogdan commented Sep 12, 2020

Rigth, presumably we don't need to override texinfo` version anymore then?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allegro 4.4.3: Malformed UTF-8 character (fatal)
3 participants
@WhittlesJr @pbogdan @7c6f434c