Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.nmigen: fix build #97617

Merged
merged 1 commit into from Sep 10, 2020
Merged

python3Packages.nmigen: fix build #97617

merged 1 commit into from Sep 10, 2020

Conversation

drewrisinger
Copy link
Contributor

Motivation for this change

Fix pythonPackages.nmigen build, which was failing due to test errors. Fixed by disabling tests. More notes about debugging this failure can be seen in commit message.

ZHF: #97479

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@drewrisinger
python3Packages.nmigen: fix build
275718d 
Tried to debug failure & traced it to subprocess.Popen calling fork_exec()
with a bad path, but couldn't reproduce error from manual debugging
using ``nix-shell``.

Bad path meaning that most paths were of form /nix/store/.../bin/sby,
but one path was "sby" only. That's my only guess as to what would
be causing this failure.
@drewrisinger drewrisinger added the 9.needs: port to stable A PR needs a backport to the stable release. label Sep 10, 2020
jonringer
jonringer approved these changes Sep 10, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 97617 1

8 packages built:
  • glasgow (python38Packages.glasgow)
  • python37Packages.glasgow
  • python37Packages.nmigen
  • python37Packages.nmigen-boards
  • python37Packages.nmigen-soc
  • python38Packages.nmigen
  • python38Packages.nmigen-boards
  • python38Packages.nmigen-soc

@jonringer jonringer merged commit b03c729 into NixOS:master Sep 10, 2020
@emilazy
Copy link
Member

emilazy commented Sep 10, 2020

Thanks for this; I'll try and look at what's causing these tests to fail in more detail soon but don't currently have access to a Nix installation.

@drewrisinger drewrisinger mentioned this pull request Sep 10, 2020
Merged
10 tasks
@veprbl veprbl added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Sep 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@emilazy emilazy Awaiting requested review from emilazy

Assignees
No one assigned
Labels
8.has: port to stable A PR already has a backport to the stable release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@drewrisinger @emilazy @jonringer @veprbl