Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/nginx: remove option enableSandbox #97631

Merged
merged 1 commit into from Sep 10, 2020
Merged

Conversation

Izorkin
Copy link
Contributor

@Izorkin Izorkin commented Sep 10, 2020

Motivation for this change

Fixed #97611

cc @Mic92 @Ma27 @flokli @aanderse

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@flokli
Copy link
Contributor

flokli commented Sep 10, 2020

Rebased on master, then successfully built the manual and ran the nginx-sandbox test.

@flokli flokli merged commit 4846329 into NixOS:master Sep 10, 2020
@flokli
Copy link
Contributor

flokli commented Sep 10, 2020

cherry-picked into 20.09 via 5358966.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/what-does-mkdefault-do-exactly/9028/1

@Izorkin Izorkin deleted the nginx-sandboxing branch November 24, 2020 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

services. nginx.enableSandbox still exists
3 participants