Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/systemd-boot: Temporarily ignore errors #97689

Merged
merged 1 commit into from Sep 11, 2020
Merged

nixos/systemd-boot: Temporarily ignore errors #97689

merged 1 commit into from Sep 11, 2020

Conversation

TethysSvensson
Copy link
Contributor

This is a temporary fix for #97433. A more proper fix has been
implemented upstream in systemd/systemd#17001, however until it gets
backported, we are stuck with ignoring the error.

After the backport lands, this commit should be reverted.

CC: @flokli

Motivation for this change

See this comment on the issue.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

flokli
flokli requested changes Sep 10, 2020
View reviewed changes
Copy link
Contributor

@flokli flokli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add a comment above linking to the issue as well.

@TethysSvensson
nixos/systemd-boot: Temporarily ignore errors
b32701b 
This is a temporary fix for NixOS#97433. A more proper fix has been
implemented upstream in systemd/systemd#17001, however until it gets
backported, we are stuck with ignoring the error.

After the backport lands, this commit should be reverted.
@TethysSvensson
Copy link
Contributor Author

Please also add a comment above linking to the issue as well.

Done

@flokli
Copy link
Contributor

flokli commented Sep 11, 2020

LGTM, and tested switching my systems to a version with this PR - (even though on my systems bootctl didn't do a nonzero exit before)

@flokli flokli merged commit 56456fe into NixOS:master Sep 11, 2020
@flokli
Copy link
Contributor

flokli commented Sep 11, 2020

@TethysSvensson this also needs to be backported to 20.09, right?

@flokli
Copy link
Contributor

flokli commented Sep 11, 2020

Backported to 20.09 in cda641e.

@TethysSvensson TethysSvensson deleted the issue-97433 branch September 12, 2020 16:43
@flokli flokli mentioned this pull request Sep 15, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flokli flokli Awaiting requested review from flokli

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@TethysSvensson @flokli