maintainers/build: skip packages that don't evaluate #97647
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
build.nix
fails when it selects packages that have disabled Python pkgs (like withdisabled = !isPy3k;
) as dependencies.Example
Explanation:
python27Packages.djangoql
is notdisabled
but has thedisabled
Py3k-only dependencydjango
.Discussion
To check which pkgs should be built,
build.nix
only evaluates themeta.maintainers
attribute of each pkg.If the maintainer doesn't match or if evaluation of
meta.maintainers
fails, the package is skipped.When a pkg is selected to be built but one of its dependencies is disabled the build fails.
The workaround to skip all packages whose closure doesn't evaluate is not ideal as this may ignore actual package defects.
But most of these potential eval failures should already get caught by
ofborg
before merging.This is relevant for ZHF: #97479
I'll add a backport in case this PR gets merged.