Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pytorch: update to use passthru's for checks #97698

Merged
merged 1 commit into from Sep 12, 2020
Merged

pytorch: update to use passthru's for checks #97698

merged 1 commit into from Sep 12, 2020

Conversation

matthewbauer
Copy link
Member

This makes the checks a little easier to understand - we can just
check it in the passthru. Also increase major check for cuda 11.

@matthewbauer
pytorch: update to use passthru's for checks
c85fc34 
This makes the checks a little easier to understand - we can just
check it in the passthru. Also increase major check for cuda 11.
jonringer
jonringer approved these changes Sep 10, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM

cc @bhipple @danieldk

danieldk
danieldk approved these changes Sep 11, 2020
View reviewed changes
Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works great!

@bhipple bhipple merged commit 931c4f2 into NixOS:master Sep 12, 2020
@bhipple
Copy link
Contributor

bhipple commented Sep 12, 2020

LGTM, can you backport to 20.09 as well?

@jonringer jonringer added the 9.needs: port to stable A PR needs a backport to the stable release. label Sep 13, 2020
@matthewbauer
Copy link
Member Author

LGTM, can you backport to 20.09 as well?

Yes, done in 914d526

@veprbl veprbl added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Sep 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldk danieldk danieldk approved these changes

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@matthewbauer @bhipple @danieldk @jonringer @veprbl