Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: c3dea4d11562
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: 5500dc83c366
Choose a head ref
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Sep 10, 2020

  1. test-driver.py: fix VM state directory deletion 

    The previous version of the code would only kick in if the state
directory path pointed at a *file*, which never occurs. Making that
codepath actually work reveals an ordering bug, which this patch fixes
as well.

It also replaces the confusing, imperative case log message "delete VM
state directory" with "deleting VM state directory".

Finally, we hint the user about how to prevent this deletion. IE. by
passing the --keep-vm-state flag.

Bug report:
#91046 (comment)

Credit goes to Edef for the rebase on top of a recent nixpkgs commit
and for writing most of this commit message.

Co-authored-by: edef <edef@edef.eu>
(cherry picked from commit ecb73fd)
    @picnoir @flokli
    picnoir authored and flokli committed Sep 10, 2020
    Copy the full SHA
    5500dc8 View commit details
    Browse the repository at this point in the history